Migrate production bundle to esbuild#481
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
CI note: the lint job passed. The build matrix jobs currently fail before npm install/tests at the |
ddf2337 to
f29370c
Compare
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
|
Follow-up after rechecking the migration:
Fresh CI lint passed on the amended commit. The build matrix is still failing before npm/tests at apt package fetch ( |
f29370c to
e0a93d1
Compare
|
Addressed the Socket Verification after the change:
|
Related to #420.
This migrates the root production bundle from webpack to esbuild, which was called out in the bounty thread as the first useful change to import/adapt.
Changes:
webpackprepare step withnode build.jsprocess/Bufferinjectionviewer/lib/utils->utils.web.jsbrowser replacementVerification:
npm run lintnode build.jsNotes:
npm installfailed locally before verification because the existingglnative dependency could not build on Node 24/macOS arm64 (python: command not foundfrom the dependency build). I installed with--ignore-scriptsto verify the JS changes.npm run preparethen fails locally atviewer/prerender.jsbecausecanvasnative bindings are absent after the script-disabled install. The new esbuild step itself succeeds.npm run jestTestcould not start because Puppeteer Chrome 127 is not installed in this local cache.IssueHunt: https://oss.issuehunt.io/repos/271385423/issues/420