Add sendsClientTickEndPacket feature flag for 1.21.2+#1208
Open
iiroak wants to merge 1 commit into
Open
Conversation
iiroak
added a commit
to iiroak/mineflayer
that referenced
this pull request
Jul 21, 2026
Replace the hardcoded 1.21.2 version check with the sendsClientTickEndPacket feature flag from minecraft-data, matching the project convention of driving protocol behavior via supportFeature. Depends on PrismarineJS/minecraft-data#1208.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new PC feature flag
sendsClientTickEndPacketdescribing that the client sends atick_endpacket at the end of every tick, starting in Minecraft 1.21.2.{ "name": "sendsClientTickEndPacket", "description": "client sends a tick_end packet at the end of every tick", "versions": ["1.21.2", "latest"] }Motivation
This is the accompanying minecraft-data PR requested for PrismarineJS/mineflayer#3948, which fixes GrimAC
TickTimerfailures (PrismarineJS/mineflayer#3800) by emitting atick_endpacket each physics tick on 1.21.2+. Per project convention, mineflayer must gate this behavior on a named feature flag viasupportFeatureinstead of a hardcoded version check.Verification
schemas/features_schema.json.supportFeature('sendsClientTickEndPacket')resolves tofalseon 1.21.1 andtrueon 1.21.2, 1.21.3, 1.21.4, 1.21.11.Related: PrismarineJS/mineflayer#3948, PrismarineJS/mineflayer#3800