Refine slide mark and deck metadata - #3
Conversation
There was a problem hiding this comment.
Code Review
This pull request centralizes deck metadata—including titles, speaker information, and export filenames—into a single deckMeta.js configuration file, with corresponding updates to the documentation and the OverviewSlide component. Additionally, it includes visual refinements to the halo-mark decoration within the presentation frame. A high-severity issue was identified in OverviewSlide.jsx where attempting to render the speaker object directly could cause a React runtime error; a code suggestion was provided to ensure the component safely handles both string and object metadata types.
There was a problem hiding this comment.
Pull request overview
Refines the presentation’s “halo mark” decoration and centralizes cover speaker info into shared deck-level metadata, with documentation updates to guide future edits.
Changes:
- Updated the halo mark layout (restored corner, rotated dot cluster, and adjusted sizing/positioning).
- Moved cover slide speaker data into
src/content/deckMeta.jsand consumed it from the cover slide. - Documented the new deck metadata shape/usage in
README.md,README_ZH.md, andAGENTS.md.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/styles/global.css | Adjusts halo mark geometry and adds a rotated dot-group wrapper style. |
| src/presentation/SlideFrame.jsx | Wraps halo dots in a container to enable rotation and adds a third dot. |
| src/content/slides/OverviewSlide.jsx | Reads cover title/speaker from deck metadata instead of local per-slide copy. |
| src/content/deckMeta.js | Introduces deckMeta object and exports deckTitle, deckSpeaker, deckFilenameStem aliases. |
| README.md | Documents how to edit deck metadata (title/speaker/filename stem). |
| README_ZH.md | Chinese documentation for the same deck metadata workflow. |
| AGENTS.md | Notes that deck metadata should live in deckMeta.js, not inside slide components. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Summary
Tests