Skip to content

Refine slide mark and deck metadata - #3

Merged
hiyouga merged 2 commits into
mainfrom
codex/update-slide-mark-metadata
May 18, 2026
Merged

Refine slide mark and deck metadata#3
hiyouga merged 2 commits into
mainfrom
codex/update-slide-mark-metadata

Conversation

@hiyouga

@hiyouga hiyouga commented May 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • refine the top-right slide mark with a restored corner, rotated uneven dots, and updated positioning
  • move cover speaker information into deck metadata
  • document deck metadata in README, README_ZH, and AGENTS

Tests

  • npm run build

Copilot AI review requested due to automatic review settings May 16, 2026 09:01

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request centralizes deck metadata—including titles, speaker information, and export filenames—into a single deckMeta.js configuration file, with corresponding updates to the documentation and the OverviewSlide component. Additionally, it includes visual refinements to the halo-mark decoration within the presentation frame. A high-severity issue was identified in OverviewSlide.jsx where attempting to render the speaker object directly could cause a React runtime error; a code suggestion was provided to ensure the component safely handles both string and object metadata types.

Comment thread src/content/slides/OverviewSlide.jsx Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refines the presentation’s “halo mark” decoration and centralizes cover speaker info into shared deck-level metadata, with documentation updates to guide future edits.

Changes:

  • Updated the halo mark layout (restored corner, rotated dot cluster, and adjusted sizing/positioning).
  • Moved cover slide speaker data into src/content/deckMeta.js and consumed it from the cover slide.
  • Documented the new deck metadata shape/usage in README.md, README_ZH.md, and AGENTS.md.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/styles/global.css Adjusts halo mark geometry and adds a rotated dot-group wrapper style.
src/presentation/SlideFrame.jsx Wraps halo dots in a container to enable rotation and adds a third dot.
src/content/slides/OverviewSlide.jsx Reads cover title/speaker from deck metadata instead of local per-slide copy.
src/content/deckMeta.js Introduces deckMeta object and exports deckTitle, deckSpeaker, deckFilenameStem aliases.
README.md Documents how to edit deck metadata (title/speaker/filename stem).
README_ZH.md Chinese documentation for the same deck metadata workflow.
AGENTS.md Notes that deck metadata should live in deckMeta.js, not inside slide components.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/content/slides/OverviewSlide.jsx
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@hiyouga
hiyouga merged commit 9e10a13 into main May 18, 2026
4 checks passed
@hiyouga
hiyouga deleted the codex/update-slide-mark-metadata branch May 18, 2026 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants