Skip to content

[codex] follow-up blog benchmark fixes - #18

Merged
Saigyouji-Yuyuko1000 merged 2 commits into
mainfrom
codex/blog-followup-updates
Jun 19, 2026
Merged

[codex] follow-up blog benchmark fixes#18
Saigyouji-Yuyuko1000 merged 2 commits into
mainfrom
codex/blog-followup-updates

Conversation

@hiyouga

@hiyouga hiyouga commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

What changed

  • Fixed the Chinese spacing around SDK in the blog copy.
  • Kept the benchmark caption/header fixed on mobile while only the benchmark table content scrolls horizontally.
  • Split fewshot and reflect into separate color families so the two modes are easier to distinguish.

Context

PR #17 was already merged. This branch was rebuilt from the latest main and only cherry-picks the follow-up commits that landed after that merge.

Validation

  • npm run build

@hiyouga
hiyouga marked this pull request as ready for review June 19, 2026 09:27
Copilot AI review requested due to automatic review settings June 19, 2026 09:27

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the benchmark visualization styles by introducing reusable CSS variables for the 'fewshot' and 'reflect' modes across light and dark themes, replacing hardcoded color values. It also wraps the benchmark columns and rows in a new scrollable container class to improve overflow handling on smaller screens, and corrects a minor spacing typo in the Chinese translation content. I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR applies follow-up polish to the site blog benchmark UI and related styling, improving mobile usability and making benchmark modes easier to distinguish visually.

Changes:

  • Introduces distinct CSS color variables for fewshot (mapped from demo) vs reflect, and updates benchmark/legend styling to use them.
  • Prevents the benchmark figure caption/header from horizontally scrolling on mobile by moving horizontal overflow to a new inner .blog-benchmark-table wrapper.
  • Fixes Chinese typography spacing around “SDK” in the blog copy.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
site/styles.css Adds --fewshot/--reflect color families (light/dark) and updates benchmark/legend styling; moves horizontal scrolling to .blog-benchmark-table.
site/src/content/blog.js Adjusts Chinese copy to include proper spacing in “评估 SDK”.
site/src/components/BenchmarkFigure.jsx Wraps benchmark columns/rows in .blog-benchmark-table so only the table content scrolls horizontally.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Saigyouji-Yuyuko1000
Saigyouji-Yuyuko1000 merged commit 982a351 into main Jun 19, 2026
1 check passed
@Saigyouji-Yuyuko1000
Saigyouji-Yuyuko1000 deleted the codex/blog-followup-updates branch June 19, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants