Repository navigation
Raise the skrub floor to 0.10.1 to fix the highest-resolution CI legs #1367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Raise the minimum `skrub` version from 0.7 to 0.10.1. joblib 1.6.0 stopped vendoring cloudpickle, so `joblib.externals.cloudpickle` no longer exists, and skrub versions below 0.10.1 import it from there. Installing TabPFN alongside joblib 1.6.0 and an older skrub made `import tabpfn` fail with an `ImportError`. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,7 +22,7 @@ dependencies = [ | |
| "filelock>=3.11.0", | ||
| "lightgbm>=4.4", | ||
| # Capped: skrub is pre-1.0 and its minor releases change transformer behavior. | ||
| "skrub>=0.7,<0.11", | ||
| "skrub>=0.10.1,<0.11", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Skrub floor raised to 0.10.1Medium Severity The Triggered by learned rule: skrub>=0.7,<0.11; no extra joblib pin Reviewed by Cursor Bugbot for commit 697184b. Configure here. |
||
| # For plotting utils; skrub already pulls it in transitively anyway. | ||
| "matplotlib>=3.6.1", | ||
| "mlx>=0.29.3; sys_platform == 'darwin' and platform_machine == 'arm64'", | ||
|
|
||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog diagnoses the joblib incident
Low Severity
The towncrier fragment retells the joblib 1.6 cloudpickle break, names
joblib.externals.cloudpickle, and narrates install history. That is incident diagnosis and internals. The change is CI plumbing for the highest-resolution legs, not a user-facing API change.Triggered by learned rule: Towncrier fragments: user-facing change only; keep concise
Reviewed by Cursor Bugbot for commit 697184b. Configure here.