Repository navigation
RDCON - BUGFIX - Fill the netcdf cell grid whatever the Galerkin output flags - #327
Merged
Merged
Conversation
…ut flags gal_output_solution filled cellinfos (interval_icell, iitvl, etypes, cell_x1, cell_x2) after its early return on bin_delmatch/out_galsol/bin_galsol, but rdcon_netcdf writes cellinfos whenever it is allocated. With those flags off the netcdf got uninitialised memory (interval_icell = -1074790400, ..., cell_x2 ~ 1e300). The fill now runs before the return. DIIID_resistive_example: Delta' and every other variable unchanged; with the flags off the cell variables now equal the flags-on run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
StuartBenjamin
added a commit
to StuartBenjamin/GPEC-1
that referenced
this pull request
Oct 18, 2026
…lerkin output flags) into PSFC_dev
StuartBenjamin
marked this pull request as draft
October 19, 2026 07:57
StuartBenjamin
marked this pull request as ready for review
October 23, 2026 02:13
StuartBenjamin
pushed a commit
to StuartBenjamin/GPEC-1
that referenced
this pull request
Oct 23, 2026
PrincetonUniversity#327 PrincetonUniversity#328 PrincetonUniversity#329 PrincetonUniversity#335 merged upstream; + 63328e4 STRIDE naive packing within nIntervalsTot, 0d6b30f docs) into PSFC_dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rdcon_netcdf.fwrites the Galerkin cell grid (interval_icell,iitvl,etypes,cell_x1,cell_x2) whenevercellinfosis allocated, butgal_output_solutionfills it only after its early return onbin_delmatch/out_galsol/bin_galsol. With all three off, the netcdf output gets uninitialised memory. This moves the fill before the return.DIIID_resistive_examplewith the three flags set tof:interval_icell[0:3]cell_x2maxWith the flags on (the shipped deck) the output is bit-identical, and the flags-off cell variables now equal the flags-on ones.
🤖 Generated with Claude Code