fix: include git history guard prompt when the bash tool is active - #172
Draft
samsja wants to merge 1 commit into
Draft
fix: include git history guard prompt when the bash tool is active#172samsja wants to merge 1 commit into
samsja wants to merge 1 commit into
Conversation
The bash tool enforces the git-log history guard but only ipython counted as a shell tool for prompt purposes, so bash-only agents got refusals they were never warned about. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The bash tool enforces the git-log history guard (
find_blocked_command→ refusal), butSHELL_TOOL_NAMESonly countedipythonas a shell tool for prompt purposes. A bash-tool agent without ipython therefore gotGit history option '--all' is not allowedrefusals withoutGIT_HISTORY_GUARD_PROMPTever telling it the restriction exists.One-word fix: add
bashtoSHELL_TOOL_NAMESso the guard prompt is included whenever any guarded shell tool is active (still omitted whenallow_git=trueor no shell tool is enabled). Extended the existing prompt test to cover the bash case.uv run pytest tests/— 164 passed.🤖 Generated with Claude Code