Skip to content

fix(AdminController): ob_end_clean without content creates error #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kaikina wants to merge 5 commits into
base: dev
Choose a base branch
from
+8 −2
Open

fix(AdminController): ob_end_clean without content creates error #121

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ff27fc9
fix(AdminController): ob_end_clean without content creates error
Kaikina Feb 2, 2026
ebc4bf8
Cs Fixer
Touxten Feb 20, 2026
9b76b48
CSFixer
Touxten Feb 20, 2026
94a96b0
CsFixer
Touxten Feb 20, 2026
e780cb1
CS Fixer
Touxten Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions controllers/admin/AdminConfigureSlidesController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@ class AdminConfigureSlidesController extends ModuleAdminController
public function ajaxProcessUpdateSlidesPosition()
{
if (empty(Tools::getValue('action')) || Tools::getValue('action') != 'updateSlidesPosition' || empty(Tools::getValue('slides'))) {
ob_end_clean();
if (ob_get_contents()) {
ob_end_clean();
}

header('Content-Type: application/json');
$this->ajaxRender(json_encode(['error' => true]));
exit;
Expand All @@ -40,7 +43,10 @@ public function ajaxProcessUpdateSlidesPosition()
// Wipe module cache
$this->module->clearCache();

ob_end_clean();
if (ob_get_contents()) {
ob_end_clean();
}

header('Content-Type: application/json');
$this->ajaxRender(json_encode(['success' => true]));
exit;
Expand Down
Loading