Assign language to the facets template so theme overrides can read it

[boo-code]

Questions	Answers
Description?	renderFacets() never assigned language to Smarty, so theme overrides that read it (Hummingbird's price/weight slider uses {$language.is_rtl} for data-slider-direction) get a null language and Smarty raises "offset on value of type null". This assigns the context language alongside the other facet variables.
Type?	bug fix
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes PrestaShop/PrestaShop#41846
How to test?	See below.
Sponsor company

Description

SearchProvider::renderFacets() assigns the facet variables to Smarty but never assigns language. Themes that override facets.tpl and reference the language break as a result: the Hummingbird price/weight slider uses {$language.is_rtl} to set data-slider-direction, so on that theme $language is null and Smarty raises:

Trying to access array offset on value of type null

in facets.tpl.php (around line 491), which breaks the faceted-search block (reported on the develop PrestaShop branch with the Hummingbird theme).

The fix assigns the context language alongside the other facet variables so the template — and any theme override — can read it safely. The default (classic) theme is unaffected because it does not reference $language in this template.

How to test

1. Use the Hummingbird theme with the faceted search module on a category page.
2. Before the fix: the price/weight slider block triggers the Smarty offset on value of type null error.
3. After the fix: the facets block renders with no error and the slider direction resolves from the shop language.

Unit test: SearchProviderTest asserts renderFacets() now assigns language (3 tests, 40 assertions, green; reverting the source change makes the test fail).

[ps-jarvis]

Hello @boo-code!

This is your first pull request on ps_facetedsearch repository of the PrestaShop project.

Thank you, and welcome to this Open Source community!

[jolelievre]

Thanks @boo-code

[SiraDIOP]

Hello @boo-code,

Thanks for your PR , i tested it :

Environment: dev branch, Docker (prestashop-develop-prestashop-git-1), Hummingbird theme, ps_facetedsearch module updated to this PR's branch, cache cleared.
Steps:

Checked out PR #1257 branch, ran composer install --no-dev -o.
Deployed the module into the container, cleared Smarty/var cache, ran module upgrade ps_facetedsearch.
Switched front office theme to Hummingbird.
Opened a category page with faceted search active.

Result: Fatal error, category page does not render:
Fatal error: Uncaught Error: Cannot use object of type Language as array in .../facets.tpl.php:491
Root cause: SearchProvider::renderFacets() now assigns 'language' => $this->module->getContext()->language (the raw Language object). facets.tpl reads it via {$language.is_rtl}, which Smarty compiles to array access. Language does not implement ArrayAccess, so this throws a fatal error.
Impact: This does not fix #41846, it makes it worse. Before this PR, the page rendered with a warning and degraded slider markup. After this PR, the category page is fully broken (fatal error) on Hummingbird.
Marking as blocking.

Did i miss something?

Thanks

[boo-code]

Thanks @SiraDIOP, and apologies for the regression — you are right, good catch. Assigning the raw Language object was my mistake: the template reads it with Smarty array syntax ({$language.is_rtl}), and Language (an ObjectModel) does not implement ArrayAccess, so on PHP 8 it throws the fatal you saw, turning the original warning into a hard error exactly as you reported.

I have pushed a fix (9df4518): renderFacets() now assigns language as an array, mirroring the language the front controller assigns globally via ObjectPresenter, so {$language.is_rtl} resolves as expected.

Verified:

• Rendering {$language.is_rtl} with the raw object reproduces Cannot use object of type Language as array; with the array it renders (data-slider-direction="0" for an LTR language).
• Updated SearchProviderTest; the full module suite is green (100 tests, 929 assertions).

Could you re-test on Hummingbird when you have a moment? Thanks again for catching this.

[SiraDIOP]

Hello @boo-code ,
Thanks for your PR. I retested it and it works fine for me, but I can't approve it until the code review is complete and the CI is green.

Thanks

[ps-jarvis]

PR merged, well done!

Message to @PrestaShop/committers: do not forget to milestone it before the merge.