Skip to content

product price indexation omit country#1226

Open
Markus-Gurkcity wants to merge 2 commits into
PrestaShop:devfrom
Markus-Gurkcity:dev
Open

product price indexation omit country#1226
Markus-Gurkcity wants to merge 2 commits into
PrestaShop:devfrom
Markus-Gurkcity:dev

Conversation

@Markus-Gurkcity

@Markus-Gurkcity Markus-Gurkcity commented May 4, 2026

Copy link
Copy Markdown
Questions Answers
Description? Indexing product prices creates a large number of entries in the database, making the table very large. In many cases, however, some data can be omitted, for example, if you only want to include one country in the index.
With this fix, instead of writing prices for every country, only the price for the shop's default country is written to the index table.
Type? improvement / new feature
BC breaks? no
Deprecations? no
Fixed ticket?
How to test?
Sponsor company

This is a example for 14.000 products:

Screenshot 2026-05-04 124629 Screenshot 2026-05-04 124713

And here after the fix:
Screenshot 2026-05-04 132008

@ps-jarvis

Copy link
Copy Markdown

Hello @Markus-Gurkcity!

This is your first pull request on ps_facetedsearch repository of the PrestaShop project.

Thank you, and welcome to this Open Source community!

@github-project-automation github-project-automation Bot moved this to Ready for review in PR Dashboard May 4, 2026
kpodemski
kpodemski previously approved these changes Jun 22, 2026
@ps-jarvis ps-jarvis added the Waiting for QA Status: Action required, Waiting for test feedback label Jun 22, 2026
@kpodemski kpodemski added this to the 5.0.0 milestone Jun 22, 2026
@ps-jarvis ps-jarvis moved this from Ready for review to To be tested in PR Dashboard Jun 22, 2026

@Hlavtox Hlavtox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, but I would personally prefer to reverse the condition - instead of “don't index countries” do “index countries”.

Also, what about storing 0 as id_country instead? It would be probably cleaner.

@ps-jarvis ps-jarvis added the waiting for author Waiting for author's feedback label Jun 22, 2026
@ps-jarvis

Copy link
Copy Markdown

This pull request seems to contain new translation strings. I have summarized them below to ease up review:

  • Modules.Facetedsearch.Admin
    • Index prices by countries
    • Index prices by countries option allows you to enable or disable the indexing of prices for different countries in the layered navigation filters. Turn this off when you do not need country-specific pricing.

(Note: this is an automated message, but answering it will reach a real human)

@Markus-Gurkcity

Markus-Gurkcity commented Jun 23, 2026

Copy link
Copy Markdown
Author

@Hlavtox I reversed the condition from omit countries to index countries. And I changed the default country to 0 as requested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting for author Waiting for author's feedback Waiting for QA Status: Action required, Waiting for test feedback

Projects

Status: To be tested

Development

Successfully merging this pull request may close these issues.

4 participants