Conversation
GitHub add issue to project workflow
Replace the Docker-based phpstan.sh approach with the shared PrestaShop/.github PHPStan action. The old approach was failing because the prestashop/prestashop:latest Docker image now exits immediately (due to entrypoint changes), causing "No such container: temp-ps" errors. - Add tests/php/phpstan/ with version-specific neon configs for 8.1.7, 8.2.x, 9.1.x and develop - Add prepend-constants.php for PS 9.x bootstrap constants - Replace single Docker-based phpstan job with two action-based jobs: phpstan-74 (PS 8.x, PHP 7.4-8.1) and phpstan (PS 9.x, PHP 8.1-8.5) - Remove tests/phpstan.sh (no longer needed) Fixes #ISSUE Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add missing blank line after <?php in index.php (php-cs-fixer) - Add ignoreErrors for pre-existing PHPStan errors on PS 8.x Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Declare the full row shape returned by executeS() via a @var PHPDoc and stop mutating $row['http_referer'] (use a local $httpReferer variable), so PHPStan no longer narrows $row to array{http_referer: string} and correctly recognizes the request_uri and nb offsets. Cast nb to int for the counter arithmetic. Removes the now-unneeded ignoreErrors from the PS 8.x PHPStan configs. Fixes #45 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…figs The PHPStan CI no longer covers PS 1.7.x / 8.0 (the shared PrestaShop/.github action targets 8.1.7+). Bump ps_versions_compliancy min from 1.7.7 to 8.1.0 so the declared support matches what CI actually verifies, consistent with sibling native modules (ps_googleanalytics, ps_emailsubscription). Also remove the orphaned tests/phpstan/ directory (1.7.7/1.7.8/8.0/latest neon configs) left behind by the migration to tests/php/phpstan/ — no workflow references it anymore. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
All four version-specific PHPStan configs now contain only the `includes` block, removing the leftover empty `parameters: / ignoreErrors:` scaffolding that suppressed nothing. Consistent across versions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Drop the 8.1.7 target to match the project-wide module cleanup Epic which standardizes native modules on PS 8.2+: - php.yml: phpstan-74 matrix now runs against 8.2.x only (PHP 7.4/8.1) - ps_versions_compliancy min bumped 8.1.0 -> 8.2.0 - remove the now-unreferenced phpstan-8.1.7.neon config Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…9.0.3 - php-linter: add missing intermediate syntax checks (7.3, 8.1, 8.2, 8.3, 8.4) - phpstan-74: lower floor to PHP 7.2 (real minimum for PS 8.2.x) - phpstan: add PrestaShop 9.0.3 (tag) + neon config Part of PrestaShop/PrestaShop#41648 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Jonathan Lelievre <jo.lelievre@gmail.com>
PrestaShop 9.0.x supports PHP 8.1 up to 8.4 only, so the cross-product matrix was generating an invalid 9.0.3 x 8.5 combination. Switch to an explicit include list so each PrestaShop version tests its proper PHP floor and ceiling (9.0.3: 8.1/8.4, 9.1.x and develop: 8.1/8.5). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
CI: migrate PHPStan to PrestaShop/.github action
jolelievre
approved these changes
Jun 19, 2026
ps-jarvis
added
the
Waiting for QA
kpodemski
approved these changes
Jun 22, 2026
Contributor
|
No functional changes, merged. Thanks @mattgoud |
kpodemski
added
QA ✔️
Contributor
|
We should definitely fix the draft release to prevent any accidents, it should take the version from config.xml or PHP file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge
devintomasterto release v4.0.0.Includes the PrestaShop 8.2+ CI/compatibility alignment (Epic PrestaShop/PrestaShop#41648) and the module version bump to 4.0.0 (minimum PS version raised to 8.2.0 → major / BC break).
After merge, the push to⚠️ release-drafter proposes a patch tag (
mastertriggers the build workflow which creates a release draft with the module zip attached.v$NEXT_PATCH_VERSION) — the draft must be published as v4.0.0.