Fix the wishlist products sort dropdown under Bootstrap 5 themes#501
Open
boo-code wants to merge 1 commit into
Open
Fix the wishlist products sort dropdown under Bootstrap 5 themes#501boo-code wants to merge 1 commit into
boo-code wants to merge 1 commit into
Conversation
|
Hello @boo-code! This is your first pull request on blockwishlist repository of the PrestaShop project. Thank you, and welcome to this Open Source community! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProductsListContainer.vueuses the Bootstrap 4 attributedata-toggle="dropdown". PrestaShop 9's default theme (Hummingbird) ships Bootstrap 5, which only recognisesdata-bs-toggle, so its dropdown plugin never binds to the button and the.dropdown-menuis never shown. This renames the attribute todata-bs-toggle="dropdown"; the rest of the markup (.dropdown,.dropdown-menu,aria-*) is already Bootstrap 5 compatible. Thepublic/productslist.bundle.jsis updated to match the source (the same single-attribute change the production build produces)."data-toggle":"dropdown"-> Bootstrap 5 ignores it); the fix makes the button carrydata-bs-toggleso Bootstrap 5's dropdown plugin toggles the menu.