Feature: Multistore list block#613
Open
Triloworld wants to merge 2 commits into
Open
Conversation
Add id_shop for multishop purpouse
leemyongpakvn
suggested changes
Oct 31, 2023
| $sql = 'SELECT * FROM `' . _DB_PREFIX_ . 'psreassurance` pr | ||
| LEFT JOIN ' . _DB_PREFIX_ . 'psreassurance_lang prl ON (pr.id_psreassurance = prl.id_psreassurance) | ||
| WHERE prl.id_lang = "' . (int) $id_lang . '" | ||
| AND prl.id_shop = "' . (int) $id_shop . '" |
Contributor
There was a problem hiding this comment.
This line is just a small part of what PR 336 - Remove broken multishop support removed since March 2022. If we dive deeper in that PR changes, we can see to bring this line back we need to bring its prerequisite line back too.
For a whole view to make sure we won't bring an old feature back with known issues, I suggest reading the whole PR336 changes and conversation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add id_shop for multishop purpouse