fix(audit): close UI/UX audit findings + per-resource OG cards#12
Merged
Conversation
Multi-agent audit pass (29 confirmed findings, zero blockers). Majors: - README: add conditional invoices + InvoiceApprovalResolver deploy row, soften the "same contract set on all three" overclaim (resolver is Arbitrum Sepolia only). - Per-resource OG: new api/share/link endpoint + vercel rewrites so pasted /pay /claim /shop /fund /conditional-invoice links unfurl with a per-type card instead of the generic site card. Crawlers get meta; humans bounce to the SPA via ?app=1 (no redirect loop, no UI changes). Minors: - Status banner is sponsorship-aware: a low paymaster while RPC + CoFHE are green reads "Core services normal, gasless sponsorship running low" instead of red "degraded capacity". - Live ticker names all three chains. Strip internal "Wave 5" jargon from whitepaper/roadmap/offramp/insights/proof-deck. Drop "Live"/ "Fresh" real-time wording off the dated proof-deck snapshot. - a11y: --ll-faint contrast fix, persistent underline on proof-deck receipt links, <main> landmark on status/proof-deck/conditional- invoice/onboarding, real <h1> on conditional-invoice + onboarding, conditional-invoice tab title, glossed ebool/quadratic, brand-kit aria fix, de-duplicated "connect to view live counter".
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The new resource-link OG endpoint pushed api/ to 13 serverless functions; the deploy caps at 12 (#380), so the build passed but the deploy was rejected. Move both handlers into _lib (not counted) behind a single api/share/[kind].ts dispatcher: kind=proof (default) serves the /v/:proofId unfurl, kind=link serves the resource-link unfurl. The vercel.json destinations (/api/share/proof, /api/share/link) resolve to the dynamic route unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multi-agent UI/UX audit pass: 29 confirmed findings, zero blockers. Closes both safe majors (README conditional-invoice + resolver row, parity overclaim) and the OG-card major (per-resource unfurl for /pay /claim /shop /fund /conditional-invoice), plus 11 minors (status banner honesty, 3-chain live ticker, Wave-5 jargon strip, a11y landmarks/headings/contrast, tab title, glosses, de-dup counter).
Verification: app typecheck clean, api typecheck clean, voice clean (142 files), all co-located tests green (App 35, Onboarding 31, Live 27, GlobalCounter 14, Roadmap 22, HowItWorks 18, Features 22, new api/share/link 25).