Fix bug with array size mismatch - #13
Merged
AntyaDev merged 1 commit intoMar 6, 2026
Merged
Conversation
OleksPal
changed the title
OleksPal
force-pushed
the
12-fix-bug-with-array-size-mismatch-when-db-row-count-was-less-than-batch-size
branch
from
March 6, 2026 08:25
f8d0974 to
c3c66fc
Compare
AntyaDev
requested changes
Mar 6, 2026
| } | ||
|
|
||
| // Resize to actual items read | ||
| if (itemsRead < count) |
OleksPal
force-pushed
the
12-fix-bug-with-array-size-mismatch-when-db-row-count-was-less-than-batch-size
branch
from
March 6, 2026 09:58
c3c66fc to
4b9b609
Compare
AntyaDev
requested changes
Mar 6, 2026
| // If dataset is smaller than requested count, load all items and repeat them | ||
| if (DataCount < count) | ||
| { | ||
| var itemsRead = QueryItems(connection, pooledArray, 1, (int)DataCount); |
Contributor
There was a problem hiding this comment.
split this logic in 2 smaller methods. 1 for normal case and one for case when batch is > than db records
OleksPal
force-pushed
the
12-fix-bug-with-array-size-mismatch-when-db-row-count-was-less-than-batch-size
branch
from
March 6, 2026 10:34
4b9b609 to
158c5c2
Compare
AntyaDev
deleted the
12-fix-bug-with-array-size-mismatch-when-db-row-count-was-less-than-batch-size
branch
March 6, 2026 10:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.