Validate repetition parsing and Rydberg pulse semantics - #1
Open
LissanKoirala wants to merge 1 commit into
Open
Conversation
LissanKoirala
marked this pull request as ready for review
August 19, 2026 17:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resetand post-boundary CX gates that can mutate the data registerRoot cause
The parser inferred an encoder from graph roots and unique target names without checking whether each CX copied from an already encoded qubit onto a fresh target. It also treated
resetand every post-boundary CX as removable.The emitters scheduled zero-detuning global pi pulses without comparing
C6 / r^6with the Rabi amplitude. At the previous documented 4 um spacing, Pulser simulation showed that the logical-one pulse did not prepare the requested111product codeword. Braket also allowed a zero-ramp segment whose deduplicated time series began and ended above zero.User and API impact
CircuitNotSupportedErrorinstead of producing non-equivalent pulse IRbackend["interaction_coeff"]inrad/s * m^6max(C6 / r^6) / Omega <= 0.01by defaultallow_interacting=Trueremains available for explicitly non-equivalent exploratory schedules and emits a warningValidation
pytest -q(103 tests, including a Pulser state-simulation regression)ruff check src testsruff format --check src testspython -m buildtwine check dist/*