[Fix] Resolves bug 635 for inter tool invocation issue - #641
Open
Power-Maverick wants to merge 3 commits into
Open
[Fix] Resolves bug 635 for inter tool invocation issue#641Power-Maverick wants to merge 3 commits into
Power-Maverick wants to merge 3 commits into
Conversation
❌ PR Checklist — Action RequiredThe following items must be completed before this PR can be merged:
|
20 tasks
Bundle Size Report 📦
Bundle Analysis ReportsThe detailed bundle analysis reports are available in the workflow artifacts:
Download the artifacts from the workflow run to view interactive visualizations. Bundle size tracking is now active! This helps prevent bundle bloat. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces enhanced support for inter-tool invocation within the Power Platform Toolbox, focusing on robust tool resolution by package name, improved error handling, and richer logging for traceability. The changes add a new IPC channel for resolving invocation targets, improve manifest normalization to reliably extract package names, and strengthen the inter-tool invocation workflow with validation and error reporting.
Closes #635
Type of change
Changes
Inter-tool Invocation and Error Handling Improvements:
RESOLVE_INVOCATION_TARGETtoTOOL_CHANNELSand implemented its handler inToolBoxAppto resolve tools by package name or ID, with detailed logging, user notifications, and Sentry error reporting for failures (src/common/ipc/channels.ts[1]src/main/index.ts[2] [3] [4].resolveInvocationTargetmethod inToolManagerto resolve tools by ID or canonical npm package name, handling ambiguities and errors when multiple matches are found (src/main/managers/toolsManager.tssrc/main/managers/toolsManager.tsR239-R263).Manifest and Registry Enhancements:
ToolManifesttype and manifest normalization logic to include apackageNamefield, ensuring reliable package name extraction from both new and legacy manifests, and fallback to readingpackage.jsonfrom the install path when needed (src/common/types/tool.ts[1]src/main/managers/toolRegistryManager.ts[2] [3] [4].src/main/managers/toolsManager.tssrc/main/managers/toolsManager.tsL730-R755).Logging, Validation, and Error Reporting:
ToolWindowManager, including validation of caller identity, connection selection failures, and target tool launch errors. Enhanced log context for traceability and user notifications for error scenarios (src/main/managers/toolWindowManager.ts[1] [2] [3] [4] [5] [6] [7] [8].Other:
1.2.6inpackage.json.Architecture checklist
Packages (
types&validation)packages/If you did change a package:
@pptb/types(types): type definitions updated and version bumped inpackages/types/package.json@pptb/validate(validation): validation rules updated and version bumped inpackages/validation/package.jsonCode quality
pnpm run typecheckpasses with 0 errors (warnings are acceptable)pnpm run lintpasses with 0 errors (warnings are acceptable)pnpm run buildcompletes successfullyTesting
pnpm run test:unitpasses (for changes tosrc/main/,src/common/, orsrc/renderer/utilities)pnpm run test:e2epasses (for UI / navigation / end-to-end flows)pnpm run dev)Scenario tested:
Screenshots / recordings
Breaking changes
Reviewer notes