feat(composer): drop the build history so the composer sits centred - #206
Merged
Conversation
The recent-builds table is gone from the composer, and with it the reason the column was not centring. `safe center` was working correctly all along: the table made the content taller than the viewport, so it fell back to top alignment exactly as designed. Remove the table and the composer is short enough to sit in the middle of the page. RecentBuildsTable, its stylesheet and its test are deleted rather than left unused. The router wrapper its links needed went with it, since it was the only thing in the composer that navigated. Worth stating plainly: this was the ONLY surface in the app where a cancelled or failed build was visible. Home lists running builds and the library lists finished courses, so a build that was cancelled now shows up nowhere. That is a deliberate trade for the cleaner entry surface, not an oversight, and it is the thing to revisit if failed builds ever need somewhere to live. The `runs` prop stays, read only to tell a first-time visitor from a returning one so the explainer still shows once and only once. 1461 tests green. Typecheck, lint, build clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the recent-builds table from the composer, which also fixes the centring.
Why it wasn't centring
safe centerwas working correctly the whole time. The build history made the column taller than the viewport, so it fell back to top alignment, which is exactly whatsafeis for. Remove the table and the composer is short enough to sit in the middle of the page. No CSS change was needed.What went with it
RecentBuildsTable, its stylesheet and its test are deleted rather than left unused. The test harness's router wrapper went too, since that table's links were the only thing in the composer that navigated.The
runsprop stays, read only to tell a first-time visitor from a returning one, so the first-run explainer still appears once and only once.One consequence worth knowing
This was the only surface in the app where a cancelled or failed build was visible. Home lists running builds; the library lists finished courses. A build that was cancelled now appears nowhere.
That's a deliberate trade for a cleaner entry surface rather than an oversight, and it's the thing to revisit if failed builds ever need somewhere to live.
1461 tests green· typecheck, lint, build clean.