fix(reader): What?/Why? title cards on the Overview video covers - #191
Open
PouyanJay wants to merge 1 commit into
Open
fix(reader): What?/Why? title cards on the Overview video covers#191PouyanJay wants to merge 1 commit into
PouyanJay wants to merge 1 commit into
Conversation
The two Overview videos are the same in every course — the course trailer (what it covers) and the topic overview (why it matters). Give their black covers those constant title cards: 'What?' on the trailer, 'Why?' on the topic overview, so the covers read as designed rather than empty black. Bump the cover title size so a short word reads as a hero. 1367 web tests green; clean tsc + eslint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up: the black Overview covers were empty. Since the two Overview videos are constant across every course — the course trailer (what it covers) and the topic overview (why it matters) — their covers now use those as title cards: "What?" on the left, "Why?" on the right. Bumped the shared cover title size so a short word reads as a hero.
Overview cards keep their descriptive header above; the cover word is a punchy visual echo. Watch/lesson-hero covers keep their own (longer) titles.
1367 web tests green (+ an assertion the covers render What?/Why?); clean tsc + eslint. Self-reviewed against enterprise-ui (this reuses the already-reviewed shared VideoCover).