Centre the phone's opening world equidistant top and bottom - #44
Merged
Conversation
The opening frame reserved a fixed pill band, which over-reserved and pushed the world UP - the margins were not equal. Measure the floating pill's real top edge instead and frame into the space above it, so the world sits dead-centre of the visible area: equal margins left/right and top/bottom on any device (the safe-area no longer throws the centring off). Recenter uses the same measure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The opening frame reserved a fixed pill band, which over-reserved and pushed the world up (unequal margins). Now it measures the floating pills real top edge and frames into the space above it, so the world sits dead-centre: equal margins left/right and top/bottom on any device.
Verified on WebKit: left 28 = right 28, top 119 ~ bottom-to-pill 118. lint 0, check 0, unit 817/817, e2e 10/10.