Flatten segmented highlight; keep lineage framing clear of the pill - #42
Merged
Merged
Conversation
- Segmented control: drop the drop-shadow. On the near-black dark track its blur leaked past the rounded corners and read as a crooked/offset box; the selected segment is now a flat fill a clear step lighter than the track (color-mix, works in both themes), so selection reads through lightness alone. - Lineage canvas: the transport pill floats over the bottom on a phone, so recenter and the opening frame now reserve its band - the framed tree sits ABOVE the pill instead of tucking its lowest node underneath it. Desktop reserves nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up after the two fixes still read as off on a real iPhone (verified now on WebKit, Safaris engine).
Verified on WebKit: flat clean segment, recenter leaves no node under the pill. lint 0, check 0, unit 817/817, e2e 17/17.