Fix two mobile UI issues: segmented highlight + pill overlap - #41
Merged
Conversation
- Segmented control: the chosen segment took `--panel`, which lifts in light but SINKS in dark - the track is `--chip` (panel tinted lighter in dark), so the selection came out darker than the track and read as a recessed hole with a leaking shadow. Mix a little white into the thumb so it sits above the track in both themes (unchanged white in light, a genuinely lighter grey in dark). - FocusView on a phone: the workbench's last controls ended underneath the floating transport pill. The focus column is now a plain scrolling block (a grid scroll container did not count a trailing spacer in its scroll extent), with a real clearance spacer so the content scrolls fully clear of the pill.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two mobile UI issues from the screenshots.
--panel, which lifts in light but sinks in dark (the track is--chip, i.e. panel tinted lighter in dark), so the selection read as a recessed dark hole with a leaking shadow. Mixing a little white into the thumb makes it sit above the track in both themes.Verified: lint 0, check 0, unit 817/817, e2e 29/29, build OK, plus phone screenshots confirming the raised selected segment (both themes) and the cleared FocusView.