Move the lineage zoom controls into the mobile transport pill - #40
Merged
Conversation
On a phone the floating zoom cluster (- / % / + / recenter) ate a lot of the canvas. Pinch already handles zoom in/out there, so the cluster is hidden and only the useful single action - "fit the tree" - moves into the transport pill as one more bare icon. The canvas keeps its full cluster on desktop. The canvas hands its recenter up via an onrecenterready callback (the same register pattern Canvas uses); the parent passes it to the pill only while the lineage canvas is the live view, so the button is absent in the focus view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a phone the floating zoom cluster (- / % / + / recenter) ate a lot of the canvas. Pinch already handles zoom in/out there, so the cluster is hidden on mobile and the one useful action - recenter ("fit the tree") - moves into the transport pill as one more bare icon. Desktop keeps the full cluster.
The canvas hands its recenter up via an
onrecenterreadycallback (the same register patternCanvasuses); the parent offers it to the pill only while the lineage canvas is the live view, so the button is absent in the focus view.Verified: lint 0, check 0, unit 817/817, e2e 17/17 (responsive + canvas + inspector), build OK, and a functional test confirming the pill button re-frames the tree.