[codex] fix flight sql explain plan rows#885
Merged
Merged
Conversation
Test Impact PlanDeterministic summary of how this PR changes tests, CI runners, and coverage-risk signals. Summary
Signals
Coverage risk: needs review Warnings
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Flight SQL EXPLAIN streaming when Duckgres advertises a synthetic one-column plan schema but DuckDB returns native
explain_key/explain_valuerows.Root cause
GetQuerySchemaintentionally returns a one-columnphysical_plan/analyzed_planschema for EXPLAIN so schema discovery does not executeEXPLAIN ANALYZE.RowsToRecordthen sized its scan destinations from that synthetic schema, while the actual DuckDB result still had two physical columns, causingsql: expected 2 destination arguments in Scan, not 1.Changes
explain_key, explain_valuewhen paired with the synthetic one-column plan schema.explain_valueinto the Arrow record batch.*sql.Conn, matching the worker session path.Validation
go test ./duckdbservice -run TestRowsToRecordExplainUsesPlanValueColumn -count=1go test ./duckdbservice -count=1go test ./tests/integration -run TestExplain -count=1just lint