feat: add guided daily session - #33
Open
PositivePhill wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a guided pacing layer to the Daily Session screen by reusing RitualTimerBar (now generalized with optional title/subtitle) and wiring it to a RitualProvider-driven auto-advance through the session pack, with debounced TTS auto-read and a completion-in-flight guard to prevent double payout.
Changes:
- Generalize
RitualTimerBarwith optionaltitleandsubtitleso Daily Session and Rescue Flow can both use it. - Drive guided auto-advance in
SessionFlowScreenfromRitualProvider, with a debounced TTS speak and timer cleanup on pause/reset/back/dispose. - Guard
_completeSession()with a_completionInFlightflag and pause the ritual before payout to keep XP/quest logic single-shot.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/widgets/ritual_timer_bar.dart | Adds optional title/subtitle parameters and updated doc comment so the bar can be reused outside Rescue Flow. |
| lib/screens/session_flow_screen.dart | Wires RitualProvider + TtsProvider into the session: guided advance timer, debounced auto-read, PopScope/dispose cleanup, and a completion-in-flight guard around _completeSession. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| icon: Icon(Icons.close, color: colorScheme.onSurface), | ||
| onPressed: () => context.pop(), | ||
| onPressed: () { | ||
| _onPopInvokedOrClose(); |
Comment on lines
+198
to
+202
| void _onPopInvokedOrClose() { | ||
| _cancelLocalTimersOnly(); | ||
| context.read<RitualProvider>().pause(); | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Positive Phill v1.6 Guided Daily Session.
Added
Reward safety
Guardrails
Verification