Skip to content

drive the sky from environment attributes - #806

Merged
Purdze merged 2 commits into
masterfrom
sky-attributes
Oct 27, 2026
Merged

Purdze merged 2 commits into
masterfrom
sky-attributes

Conversation

@Purdze

@Purdze Purdze commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Refactor / code cleanup
  • Performance improvement
  • Chore / tooling
  • Documentation

Summary

the sky, clouds and lightmap now come from the dimension's environment attributes and its timelines, like the lightmap already did, instead of hardcoded keyframe tables.

  • resolves sky, fog, cloud and sunrise colours, star brightness, sun/moon/star angles, moon phase, cloud height and sky light level, with the weather layer's blend to gray and multipliers
  • cubic bezier and constant easing on timeline tracks, and KeyframeTrackSampler's segments
  • an attribute probe resolves them once per tick and frames lerp between ticks (angles snap on a 90 degree jump), which replaces the day time blend and also covers the lightmap
  • sky darken reads the sky light level attribute, so overworld_day goes
  • sky, fog, clear and cloud colours are converted to linear before reaching the srgb swapchain, which was brightening them (the pale noon sky and grey storm sky)

stacked under the sky renderer pr; noon only matches vanilla once that lands.

Reference

EnvironmentAttributes, EnvironmentAttributeSystem, EnvironmentAttributeProbe, WeatherAttributes, ColorModifier, ARGB, LerpFunction, KeyframeTrackSampler, EasingType, AttributeTrackSampler, Level.skyDarken, timeline/day.json, timeline/moon.json

Testing

  • unit tests for the overworld day, sun sweep, moon phases, weather, probe lerp and colour modifiers
  • world/lightmap against vanilla: thunder 73.5 to 9.7, nether 226 to 30
  • clippy with and without the harness

@github-actions github-actions Bot added bug Something isn't working enhancement New feature or request labels Oct 27, 2026
@Purdze
Purdze merged commit e6891bd into master Oct 27, 2026
14 of 15 checks passed
@Purdze
Purdze deleted the sky-attributes branch October 27, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant