Repository navigation
add a deterministic harness step - #805
Merged
Merged
Conversation
…tions, clouds and bobbing still
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Summary
adds a
deterministic = trueharness step that holds a frame's run-to-run noise still for the rest of the script: block light flicker stays at 0, animated textures stay on their first frame, ambient block effects and particles are dropped, and clouds and view bobbing are off (overridden where they're read, so options are never saved with it). two shots of the same scene now come out pixel-identical, so screenshot comparisons can be judged far tighter.world/lightmapopts in, and the newworld/deterministicscript checks a lava, magma and torch scene stays identical a second apart.Reference
n/a (test tooling)
Testing
world/deterministic: both shots identical (53k pixels differ without the step)just ingame-test: 44 of 44