Repository navigation
advance world clocks by their server rate - #804
Merged
Merged
Conversation
github-actions
Bot
added
the
merge conflict
# Conflicts: # pomme-client/src/app/phases/in_game.rs # pomme-client/src/world/mod.rs
github-actions
Bot
removed
the
merge conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Summary
world clocks now advance by the rate the server sends instead of always +1 per tick, so a paused clock (
advance_time false,/time pause) stays put. the server never resyncs a paused clock, so the sun used to drift forever. day time comes from the dimension's default clock, and the sky samples whole ticks like the attribute samplers do.Reference
ClientClockManager,ClientLevel.tickTime,ClientPacketListener.handleSetTime,Level.getDefaultClockTime,AttributeTrackSampler, serverServerClockManager.packNetworkStateTesting
clock unit tests,
world/lifecyclenow checks a frozen clock still reads 6000 after 2s (passes on pomme and the vanilla harness), clippy both ways