Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Summary
ports the menu background blur.
blur:
post_effect/blur.json's chain: three rounds of horizontal then verticalbox_blur, bilinear, full resolution, run in the post effects alongside the spectator effectsblur.rs,blur.frag) and the per-screenblurvalueBlurBackgroundmarker isblurBeforeThisStratum: elements before it are blurred in place, the rest draw sharp. in game this blurs the world and the hud, likeGuiRenderer.drawBlurBackdropand sample the same blur without touching the framewhere it runs:
Screen.extractBackgroundpush the marker: options, credits, account, server and world lists, connecting/status screens, the pause menu while shown (PauseScreen.extractBackground), and dialogsoption:
genericValueOrOffLabelstyle ("OFF" at 0), saved inoptions.json; 0 skips the blur likeextractBlurredBackgroundnot here:
inworld_menu_background; the no-levelmenu_backgroundis a separate parity fixReference
post_effect/blur.json,box_blur.fsh,Screen,PauseScreen,GuiRenderer,Options(menuBackgroundBlurriness)Testing
just client-pre-prchecks (fmt, clippy with and without the harness, client tests)just ingame-testfull native suite passes; newui/menu_blurscreenshots the pause menu at 5, 0 and 10 and in-game options