Repository navigation
outline glowing items, hide invisible mobs and flip the outline's vertical blur - #799
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Summary
finishes the glowing outline from #793.
glowing items:
OUTLINE_CULLitem pipeline; the colour rides in the item instance data and the entity outline fragment shader is reusedItemPickupParticleclears it)invisibility:
Entity.isInvisibleTo: a spectator sees it, a teammate sees it when the team sees friendly invisibles (team options bit 2, now read from the team packet), anyone else doesn'tLivingEntityRenderer.getRenderType: skipped when the viewer can't see it, outline only if it glows, and 0x26 alpha through a newentityTranslucentCullpipeline when it canRenderLayer.coloredCutoutModelCopyLayerRender), sheep wool and the slime shell keep only their outline when glowing, eyes, the creeper swirl and armour always drawoutline blur:
(0, -1): the reference's rows run bottom-up and ours top-down, and the blur's taps aren't symmetric, so the band sat under a pixel offnot here: no in-game script covers the team see-friendly-invisibles case (unit tests only).
Reference
ItemFeatureRenderer,SubmitNodeCollection.submitItem,RenderType.outline,RenderTypes,RenderPipelines,ItemPickupParticle,LivingEntityRenderer(submit,getRenderType),EntityRenderer,Entity.isInvisibleTo,PlayerTeam(packOptions,unpackOptions), the layers underrenderer/entity/layers(RenderLayer,SheepWoolLayer,SlimeOuterLayer,VillagerProfessionLayer,HorseMarkingLayer,WolfCollarLayer,IronGolemCrackinessLayer,EyesLayer,EnergySwirlLayer) andpost/entity_outline_box_blur.fshinreference/26.3.Testing
entities/glowingextended: a glowing dropped item is outlined, an invisible glowing pig and sheep show only outlines, an invisible plain pig shows nothing, and a spectator sees all three faded with the sheep's wool hidden