Skip to content
This repository was archived by the owner on Jul 21, 2022. It is now read-only.

Fix link to item when domain is null - #12

Open
rubenochiavone wants to merge 1 commit into
Polymer:masterfrom
rubenochiavone:item_link_fix
Open

Fix link to item when domain is null#12
rubenochiavone wants to merge 1 commit into
Polymer:masterfrom
rubenochiavone:item_link_fix

Conversation

@rubenochiavone

Copy link
Copy Markdown

When a list item doesn't have a domain the anchor element gets an invalid URL (probably server side API changed?). But it is possible to create a valid URL for that item using "/item/" + item.id.

I've also removed empty parentheses from title using item domain property.

Hide empty domain span element
@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@rubenochiavone

Copy link
Copy Markdown
Author

I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants