fix: harden Qwen Cloud proof entry point - #13
Conversation
Verification receiptImplementation commits:
Files:
The required compute verification command was attempted, but the sandbox returned |
|
Review-readiness result: NEEDS-CHANGES. The PR body reports compute unavailable and provides no executable CI receipt. Attach exact output for |
Verification ReceiptRequested commands for PR #13 were attempted against head Execution was blocked before clone/command execution because the compute MCP could not initialize: Therefore:
Full receipt artifact: |
Problem
PR #11 review identified unstructured
print(result)output, no concrete issue closure reference, and no CI-backed no-credential validation receipt.Root Cause
The proof script printed the full provider response directly from
__main__, which is not suitable for auditable or secret-safe execution. The repository also lacked a regression test for the required fail-closed behavior.Changes
main()entry point with a non-zero exit code and structured error event when credentials are absent.Files changed:
hackathon/qwen_integration.py, secret-safe structured logging and exit behavior.tests/test_qwen_integration.py, no-credential regression coverage.Testing
python -m py_compile hackathon/qwen_integration.py tests/test_qwen_integration.pywas prepared for execution.MCP session init failed: no session ID. status=405.Review linkage
Remaining blocker
Provider-backed Qwen deployment receipt and public demo evidence still require real credentials and an actual endpoint. This PR does not claim either.