Skip to content

fix: harden Qwen Cloud proof entry point - #13

Open
princepspolycap wants to merge 2 commits into
feat/qwen-cloud-hackathon-prooffrom
fix/qwen-cloud-pr-11-review-blockers
Open

fix: harden Qwen Cloud proof entry point#13
princepspolycap wants to merge 2 commits into
feat/qwen-cloud-hackathon-prooffrom
fix/qwen-cloud-pr-11-review-blockers

Conversation

@princepspolycap

Copy link
Copy Markdown
Contributor

Problem

PR #11 review identified unstructured print(result) output, no concrete issue closure reference, and no CI-backed no-credential validation receipt.

Root Cause

The proof script printed the full provider response directly from __main__, which is not suitable for auditable or secret-safe execution. The repository also lacked a regression test for the required fail-closed behavior.

Changes

Files changed:

  • hackathon/qwen_integration.py, secret-safe structured logging and exit behavior.
  • tests/test_qwen_integration.py, no-credential regression coverage.

Testing

  • python -m py_compile hackathon/qwen_integration.py tests/test_qwen_integration.py was prepared for execution.
  • Compute sandbox execution was attempted but unavailable in this run due to MCP session init failed: no session ID. status=405.
  • Live Qwen/Alibaba deployment was not attempted. No credentials were available, and deployment proof remains explicitly NOT VERIFIED.

Review linkage

Remaining blocker

Provider-backed Qwen deployment receipt and public demo evidence still require real credentials and an actual endpoint. This PR does not claim either.

@princepspolycap

Copy link
Copy Markdown
Contributor Author

Verification receipt

Implementation commits:

  • bc742dba3f9abfa337cd4e25c3c540bf71fbb24c, structured Qwen proof logging
  • 4f7f0055ed561f05af19212466df0e5a13dd688a, no-credential regression tests

Files:

  • hackathon/qwen_integration.py
  • tests/test_qwen_integration.py

The required compute verification command was attempted, but the sandbox returned MCP session init failed: no session ID. status=405. Therefore no passing test result is claimed. Live Qwen/Alibaba credentials and provider response were not available, so deployment proof remains NOT VERIFIED.

@princepspolycap

Copy link
Copy Markdown
Contributor Author

Review-readiness result: NEEDS-CHANGES. The PR body reports compute unavailable and provides no executable CI receipt. Attach exact output for python -m py_compile hackathon/qwen_integration.py tests/test_qwen_integration.py and pytest -q tests/test_qwen_integration.py; no-credential behavior and Fixes #12 are otherwise aligned.

@princepspolycap

Copy link
Copy Markdown
Contributor Author

Verification Receipt

Requested commands for PR #13 were attempted against head 4f7f0055ed561f05af19212466df0e5a13dd688a:

python -m py_compile hackathon/qwen_integration.py tests/test_qwen_integration.py
pytest -q tests/test_qwen_integration.py

Execution was blocked before clone/command execution because the compute MCP could not initialize:

MCP session init failed: no session ID. status=405 body=

Therefore:

  • py_compile: NOT EXECUTED
  • pytest: NOT EXECUTED
  • Live Qwen/Alibaba deployment proof: NOT VERIFIED and not attempted
  • No credentials or endpoint were used

Full receipt artifact: pr13_qwen_verification_receipt_2026-07-19.md (artifact ID c5b91de6-f7e1-457a-a0b6-b0be4a5f7df2::1.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant