Skip to content

Rework tab and context controls - #394

Open
rmmh wants to merge 5 commits into
Polprzewodnikowy:developfrom
rmmh:control-rework
Open

Rework tab and context controls#394
rmmh wants to merge 5 commits into
Polprzewodnikowy:developfrom
rmmh:control-rework

Conversation

@rmmh

@rmmh rmmh commented Aug 18, 2026

Copy link
Copy Markdown

Description

This commit moves to using L/R consistently for switching between tabs and cleans up the associated text.

Motivation and Context

This is a tiny prerequisite for the Settings tab and the Theme work.

How Has This Been Tested?

This was tested in ares with the necessary SC64 patch.

Screenshots

Types of changes

  • Improvement (non-breaking change that adds a new feature)
  • Bug fix (fixes an issue)
  • Breaking change (breaking change)
  • Documentation Improvement
  • Config and build (change in the configuration and build system, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

You agree with the license terms and that other license types may be granted with permission of the original N64FlashcartMenu project license holders.

Signed-off-by: rmmh hitchmanr@gmail.com

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 46cf283b-3f99-46b9-b107-42b06a45e3fb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@networkfusion

Copy link
Copy Markdown
Collaborator

Still considering this, though the consequence is a change in the general way the joypad was designed to work for most games. It must be considered that most users would either hold it so they have their left hand on the centre stub (with the analogue stick) or the left stub (so using the L button). This was the original reason for making L and Z a single context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants