Skip to content

[develop] non-compliant Flashram saves - #205

Draft
networkfusion wants to merge 23 commits into
Polprzewodnikowy:developfrom
networkfusion:flashram-saves-noncompliant
Draft

[develop] non-compliant Flashram saves#205
networkfusion wants to merge 23 commits into
Polprzewodnikowy:developfrom
networkfusion:flashram-saves-noncompliant

Conversation

@networkfusion

@networkfusion networkfusion commented Jan 14, 2025

Copy link
Copy Markdown
Collaborator

Description

Add a new type for non-compliant flashram saves.
Linked to: Polprzewodnikowy/SummerCart64@f546e5d

Motivation and Context

Made popular by incorrect firmware implimentation on the ED64.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that adds a new feature)
  • Bug fix (fixes an issue)
  • Breaking change (breaking change)
  • Documentation Improvement
  • Config and build (change in the configuration and build system, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: GITHUB_USER <GITHUB_USER_EMAIL>

@coderabbitai

coderabbitai Bot commented Jan 14, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@networkfusion
networkfusion force-pushed the flashram-saves-noncompliant branch from d419637 to 48e7ee6 Compare January 14, 2025 23:07
@networkfusion

Copy link
Copy Markdown
Collaborator Author

Pottentially linked: #100

@networkfusion
networkfusion force-pushed the flashram-saves-noncompliant branch from a1a482c to a80d9a2 Compare June 11, 2025 17:31
@networkfusion
networkfusion force-pushed the flashram-saves-noncompliant branch from a80d9a2 to de5b938 Compare June 11, 2025 17:37
@networkfusion
networkfusion force-pushed the develop branch 13 times, most recently from 2fd7dd7 to bfb4e22 Compare October 7, 2025 21:42
@networkfusion
networkfusion force-pushed the develop branch 2 times, most recently from c8e5336 to 4fb877a Compare November 10, 2025 01:01
@networkfusion networkfusion added roadblock firmware dependency Requires a fix in the flashcart firmware. labels Nov 17, 2025
@FrostKnight

Copy link
Copy Markdown

Would it be possible to make it possible to import saves from mupen64plus to summercart64? That would really be helpful if you could.

@Kethku

Kethku commented Jan 8, 2026

Copy link
Copy Markdown

I suspect that this save type would enable running ootmm combo randomizer. If I understand right, there is a merged but unreleased summercart firmware that implements the new save type and this PR implements that save type via a rom config. If thats correct is it a bad idea to build that firmware and test this myself?

@Kethku

Kethku commented Jan 10, 2026

Copy link
Copy Markdown

I went ahead and tested it with a new rebase on top of the current main. It works but needs an 8th save size added to the SAVE_SIZES table in flashcart.c.

Once thats added, the non compliant saves from the combo randomizer I've been testing are properly saved and reloaded even after a power cycle.

@networkfusion
networkfusion force-pushed the develop branch 3 times, most recently from ba95b9a to 15572e0 Compare May 2, 2026 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

firmware dependency Requires a fix in the flashcart firmware. roadblock

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants