[develop] non-compliant Flashram saves - #205
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
d419637 to
48e7ee6
Compare
|
Pottentially linked: #100 |
Actually, lets set the GB emus to use SRAM banked. It may break older save files.
9cf3c1f to
9b69b84
Compare
a412ade to
61e62b8
Compare
a1a482c to
a80d9a2
Compare
a80d9a2 to
de5b938
Compare
2fd7dd7 to
bfb4e22
Compare
c8e5336 to
4fb877a
Compare
b4c081d to
490ddff
Compare
|
Would it be possible to make it possible to import saves from mupen64plus to summercart64? That would really be helpful if you could. |
|
I suspect that this save type would enable running ootmm combo randomizer. If I understand right, there is a merged but unreleased summercart firmware that implements the new save type and this PR implements that save type via a rom config. If thats correct is it a bad idea to build that firmware and test this myself? |
|
I went ahead and tested it with a new rebase on top of the current main. It works but needs an 8th save size added to the SAVE_SIZES table in flashcart.c. Once thats added, the non compliant saves from the combo randomizer I've been testing are properly saved and reloaded even after a power cycle. |
ba95b9a to
15572e0
Compare
Description
Add a new type for non-compliant flashram saves.
Linked to: Polprzewodnikowy/SummerCart64@f546e5d
Motivation and Context
Made popular by incorrect firmware implimentation on the ED64.
How Has This Been Tested?
Screenshots
Types of changes
Checklist:
Signed-off-by: GITHUB_USER <GITHUB_USER_EMAIL>