Document weighting rule in AGENTS.md (never raw weights; use Microsimulation/microdf)#224
Open
MaxGhenis wants to merge 1 commit into
Open
Document weighting rule in AGENTS.md (never raw weights; use Microsimulation/microdf)#224MaxGhenis wants to merge 1 commit into
MaxGhenis wants to merge 1 commit into
Conversation
Never read or sum weight arrays directly, and never report unweighted record counts or raw HDF5 column sums as population figures. Compute population aggregates via Microsimulation (microdf auto-weights with the household weight); if a weight must be referenced at all, it is household_weight only. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codify the rule that bit us mid-MP-vs-eCPS analysis: never read/sum weight arrays directly and never use unweighted record counts or raw H5 column sums as population figures. Compute aggregates via
Microsimulation.calculate(var, year)(+ microdf auto-weighting); if a weight must be referenced at all it ishousehold_weightonly. Doc-only change to AGENTS.md.🤖 Generated with Claude Code