Skip to content

Add the Wait for Movement Completion Command#772

Open
Menthx wants to merge 2 commits into
developfrom
562-wait-for-movement-command
Open

Add the Wait for Movement Completion Command#772
Menthx wants to merge 2 commits into
developfrom
562-wait-for-movement-command

Conversation

@Menthx

@Menthx Menthx commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator
  • Remove circular dependecies
  • Make export command file possible
  • Create folder to rearrange the flow
  • display the wait completion node

Thank you for your contribution to the Pokémon Studio repo.

Before submitting this PR into the develop branch, please make sure:

  • Your code builds clean without any errors or warnings
  • You are following the Code guidelines
  • You tested your code to make sure it does what it is supposed to do

Description

Add a node command who can:
Option to wait for all events
Option to wait for specific events
Timeout option
Integration with movement commands

Tests to perform

I want events to wait for movements to complete
So that I can add some timing between event movements
Add the node associated, try to update it, save it, reload, and do the same with the editor.

@Menthx Menthx linked an issue Jun 22, 2026 that may be closed by this pull request
5 tasks
@Menthx
Menthx force-pushed the 562-wait-for-movement-command branch 3 times, most recently from 8563176 to 6bf1dbd Compare June 25, 2026 22:49
@Aelysya
Aelysya self-requested a review June 27, 2026 12:30
Comment thread assets/i18n/de.json Outdated
Comment thread assets/i18n/de.json Outdated
Comment thread src/models/entities/event/movement/waitMovementCompletion.ts
Comment thread src/models/entities/event/waitCommand/waitMovementCompletion.ts Outdated
Comment thread src/models/entities/event/command.ts

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Si la node est pas sélectionné quand je clique sur un select, il se ferme directement.

20260627-1301-34.8028800.mp4

Et si je vide les options du multi-select, en sortant ça revient à l'état précédent. Dans l'éditeur ça marche bien de faire ça.

20260627-1303-12.1092883.mp4

@AerunDev AerunDev changed the title feat(wait-movement-command): add movement command Add the Wait for Movement Completion Command Jul 14, 2026
@AerunDev

Copy link
Copy Markdown
Collaborator

Hello @Menthx, sur cette PR Aelysya a fait une revue, sais-tu quand tu pourras y jeter un œil ? Si tu n'as pas la dispo nécessaire, tu veux qu'on prenne le relai ? Merci à toi 😄

- Remove circular dependecies
- Make export command file possible
- Create folder to rearrange the flow
- display the wait completion node
@Menthx
Menthx force-pushed the 562-wait-for-movement-command branch from 6bf1dbd to 5990efa Compare July 18, 2026 13:13
@Menthx

Menthx commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator Author

Hello @Menthx, sur cette PR Aelysya a fait une revue, sais-tu quand tu pourras y jeter un œil ? Si tu n'as pas la dispo nécessaire, tu veux qu'on prenne le relai ? Merci à toi 😄

Salut @AerunDev , en effet, je n'étais pas trop disponible pour regarder, j'ai commencé à revue ce soir et je compte finir dans la semaine, les bugs remontés vont surement m'être compliqué !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wait for Movement Command

3 participants