Added option to disable TLS at runtime.#73
Merged
Merged
Conversation
Will still fall back to POLARIS_USE_TLS for backwards compatibility.
bhers4
approved these changes
May 29, 2026
bhers4
left a comment
bhers4
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me! Make sure to test this pretty thoroughly.
This should be backwards compatible: if TLS support is compiled in, it will be enabled by default.
The network now sends a 1029 message on connect indicating which stream you are connected to, so the first ~100-200 bytes are not corrections.
This library is not limited to hard-float.
adamshapiro0
force-pushed
the
ssl-option
branch
2 times, most recently
from
3332c3e to
1c9aff7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Features
Changes
POLARIS_USE_TLSmacro toPOLARIS_ENABLE_TLSPOLARIS_USE_TLSwill still be supported for backwards compatibilityFixes