Skip to content

Negative position setting fix - #639

Open
Bartman119 wants to merge 1 commit into
PoetOS:MOODLE_404_STABLEfrom
Bartman119:619-negative-position-fix
Open

Negative position setting fix #639
Bartman119 wants to merge 1 commit into
PoetOS:MOODLE_404_STABLEfrom
Bartman119:619-negative-position-fix

Conversation

@Bartman119

Copy link
Copy Markdown

Fix negative position setting for edited questionnaire and remove position updating for other questionnaires

@Bartman119

Copy link
Copy Markdown
Author

Fix regarding #619

@mchurchward

Copy link
Copy Markdown
Contributor

Thanks for this. Can you also provide a Behat test that shows the error before the fix, and no error after the fix?

@Bartman119

Copy link
Copy Markdown
Author

Sure, I will provide appropriate behat tests at the earliest convenience

Thanks for this. Can you also provide a Behat test that shows the error before the fix, and no error after the fix?

@HirotoKagotani

Copy link
Copy Markdown

How about using a placeholder just in case?

if ($records = $DB->get_records_select('questionnaire_question', 'surveyid = :sid', ['sid' => $sid], 'position ASC')) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants