fix(terraform/platform/dev): interpolate var.environment in QuanvNN bucket name + add SSE-KMS TODO#40
Merged
Conversation
…ucket name + add SSE-KMS TODO
The bucket name was hardcoded to "podyourlife-quanvnn-datasets-dev". Interpolating
${var.environment} avoids a copy-paste hazard when this file is templated for staging/prod
(literal "dev" leaking into a non-dev bucket would be silent until apply-time).
Also flags the AES256/SSE-S3 baseline as dev-only — staging/prod under compliance_profile
"soc2" should switch to SSE-KMS with a customer-managed key.
Both changes are no-ops on dev: var.environment evaluates to "dev" so the bucket name
is byte-identical and Terraform will not replace the resource.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small follow-up to PR #39 addressing the two non-blocking 🟡 nits from
PR_39_REVIEW.md:${var.environment}into the QuanvNN bucket name instead of the hardcoded"dev"literal. Avoids a copy-paste hazard when this file is templated for staging/prod (a leaked"dev"literal in a non-dev bucket would be silent until apply-time).compliance_profile = "soc2"should switch to SSE-KMS with a customer-managed key.Safety
Both changes are no-ops on dev:
var.environmentdefaults to"dev"and the devterraform.tfvarssetsenvironment = "dev", so"podyourlife-quanvnn-datasets-${var.environment}"evaluates to the exact same byte string as the prior literal. Terraform will not replace the bucket.Test plan
terraform fmt -check -diff s3.tfcleanterraform validatesucceedsterraform planshows zero changes foraws_s3_bucket.quanvnn_datasets