Skip to content

Fix/ci env branch workflows#34

Merged
JackMaarek merged 2 commits into
mainfrom
fix/ci-env-branch-workflows
Mar 27, 2026
Merged

Fix/ci env branch workflows#34
JackMaarek merged 2 commits into
mainfrom
fix/ci-env-branch-workflows

Conversation

@JackMaarek

Copy link
Copy Markdown
Collaborator

What

Why

Changes

  • path/to/file — reason

Checklist

  • Branch is based on latest main (git log --oneline main..HEAD)
  • No env-specific values on main-bound files
    grep -r "env: dev\|eu-west-3\|k8s-platform-dev\|esoIrsaRoleArn: \"\"" argocd/ kubernetes/helm/
  • No unreplaced placeholder in manifests (only allowed in ApplicationSet elements:)
    grep -r "__ENV__\|__CLUSTER_NAME__" kubernetes/manifests/ kubernetes/helm/
  • Commit messages follow Conventional Commits (type(scope): description)
  • No file exceeds 200 lines (find . -name "*.yaml" -o -name "*.go" | xargs wc -l | sort -rn | head -20)
  • No secrets or credentials committed (git diff main --name-only | xargs grep -l "password\|secret\|token\|key" 2>/dev/null)
  • ArgoCD wave order documented in comments if sync order matters
  • SRP respected — one file, one responsibility

Testing

  • kubectl apply --dry-run=server on changed manifests
  • ArgoCD sync validated on local cluster (Kind)
  • No new CrashLoopBackOff or ImagePullBackOff after sync

Notes for reviewer

--chdir changes tflint's working directory, making relative config paths
fail. $GITHUB_WORKSPACE always points to the repo root regardless of --chdir.
@JackMaarek
JackMaarek merged commit 974e285 into main Mar 27, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant