Fix/ci env branch workflows#32
Merged
Merged
Conversation
…ng, prod) The apply IAM role was scoped to refs/heads/main only. CI on env branches (dev, staging, prod) could not assume it. Extend the condition using StringLike with an explicit list of allowed branches.
The project uses env-branch model (dev/staging/prod), not main-centric. Workflows now trigger on push/PR targeting env branches. The target env is resolved from the branch name — no matrix needed. Also fix terraform-platform.yml path: _domains/platform → domains/platform.
domains/organization manages IAM Identity Center bootstrap and all account assignments. Single apply from dev branch — no per-env matrix.
…commit config __GIT_WORKING_DIR__ was never resolved by platform-bot (not in placeholderMapping, pre-commit config not a substitution target). Replace with ./terraform/_ci which works without any substitution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Changes
path/to/file— reasonChecklist
main(git log --oneline main..HEAD)main-bound filesgrep -r "env: dev\|eu-west-3\|k8s-platform-dev\|esoIrsaRoleArn: \"\"" argocd/ kubernetes/helm/elements:)grep -r "__ENV__\|__CLUSTER_NAME__" kubernetes/manifests/ kubernetes/helm/type(scope): description)find . -name "*.yaml" -o -name "*.go" | xargs wc -l | sort -rn | head -20)git diff main --name-only | xargs grep -l "password\|secret\|token\|key" 2>/dev/null)Testing
kubectl apply --dry-run=serveron changed manifestsNotes for reviewer