Skip to content

feat(sentry): add stage with sentry_sdk[flask] to dockerfile #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VincentCauchois wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feat(sentry): add stage with sentry_sdk[flask] to dockerfile #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bea92c
feat(sentry): add stage with `sentry_sdk[flask]` to dockerfile
VincentCauchois May 27, 2024
097daaa
feat(sentry): add "sentry" `extras_require` in 'setup.py'
VincentCauchois May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,21 @@ RUN --mount=type=cache,target=/root/.cache \
pip install *.whl


FROM app-${DEPS} AS prod-with-sentry

RUN --mount=type=cache,target=/root/.cache \
pip install sentry_sdk[flask]

ENV FLASK_APP=app.app:create_app
ENV PYTHONPATH=/dist/config/
ENV USERSHUB_SETTINGS=config.py
ENV USERSHUB_STATIC_FOLDER=/dist/static

EXPOSE 5001

CMD ["gunicorn", "app.app:create_app()", "--bind=0.0.0.0:5001", "--access-logfile=-", "--error-logfile=-", "--reload", "--reload-extra-file=config/config.py"]
Comment on lines +109 to +121

@jacquesfize jacquesfize Mar 4, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FROM app-${DEPS} AS prod-with-sentry
RUN --mount=type=cache,target=/root/.cache \
pip install sentry_sdk[flask]
ENV FLASK_APP=app.app:create_app
ENV PYTHONPATH=/dist/config/
ENV USERSHUB_SETTINGS=config.py
ENV USERSHUB_STATIC_FOLDER=/dist/static
EXPOSE 5001
CMD ["gunicorn", "app.app:create_app()", "--bind=0.0.0.0:5001", "--access-logfile=-", "--error-logfile=-", "--reload", "--reload-extra-file=config/config.py"]
FROM prod AS prod-with-sentry
RUN --mount=type=cache,target=/root/.cache \
pip install sentry_sdk[flask]



FROM app-${DEPS} AS prod

ENV FLASK_APP=app.app:create_app
Expand Down
3 changes: 3 additions & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,7 @@
"migrations = app.migrations:versions",
],
},
extras_require={
"sentry": ["sentry_sdk[flask]"],
},
)