Add pyvmomi and terminaltables package for nvmctl - #2
Open
ashxjain wants to merge 1 commit into
Open
Conversation
venkytv
reviewed
Apr 26, 2017
venkytv
left a comment
venkytv
left a comment
Contributor
There was a problem hiding this comment.
The changes look fine to me. The only thing is the PYTHON_VERSIONS change in shared-macros. Moinak should be a better person to judge if we want to make this change. Also, even if we keeping this, it should probably be a separate commit instead of piggy-backing on the pyvmomi/terminaltables one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.