perf(engine): build TileMaps lazily on first scene use#217
Merged
Conversation
MapResource.load() eagerly built the per-tier Excalibur TileMaps — one Tile object per cell per tier, ~1.25M objects across the 19 oot2d-2014 maps — although project preloading only needs the parsed mapData (atlas previews, snapshots, agent projections). Opening that project took ~19 s and repeated opens could OOM GJS. - load() now parses + validates the JSON and resolves sprite sets; ensureTileMaps() builds the tilemaps + editor shadow on first addToScene (idempotent; the map cache makes re-entries free) - isLoaded() gates on the parsed map data (Loadable contract) - syncShadowToMapData() already guarded the never-built case - GameProjectResource.load() logs per-phase timings at info level Measured: oot2d-2014 open is now ~1.3 s to the atlas (worst case, right after app start), scene open + engine render verified intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MapResource.load() eagerly built the per-tier Excalibur TileMaps —
one Tile object per cell per tier, ~1.25M objects across the 19
oot2d-2014 maps — although project preloading only needs the parsed
mapData (atlas previews, snapshots, agent projections). Opening that
project took ~19 s and repeated opens could OOM GJS.
ensureTileMaps() builds the tilemaps + editor shadow on first
addToScene (idempotent; the map cache makes re-entries free)
Measured: oot2d-2014 open is now ~1.3 s to the atlas (worst case,
right after app start), scene open + engine render verified intact.