fix(app): resolve the bundled trace viewer from playwright-core's install path - #422
Merged
Merged
Conversation
…tall path
The publicAssets dir for /trace-viewer/ was resolved relative to the app
directory ('../node_modules'), a path that stopped existing when the app
moved into the apps/ workspace — playwright-core is hoisted to the repo
root. Nitro silently skips a missing assets dir, so every build since
shipped without the viewer and 'View trace' opened a 404 page. The dir
is now located via module resolution, which is layout-independent, and
a test asserts the viewer page and its service worker are served.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
NicolaiHorlacher
changed the title
PhenX
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have the second external PR in this repo for you.
This is the other thing I found while testing piwi. The rest seems to be working like I expected.
Also disclaimer again: Claude did the code again. And I validated the changes only on MacOS. I'm not Nuxt expert, so I can't say if its the right fix for the issue. Thats on you to decide.
What & why
Fixes: #421
How was it tested?
Using
npm testChecklist
type(scope): subject)apps/docs/, README, or reporter README)