fix(app): sharded run accounting - #420
Merged
PhenX merged 3 commits intoAug 21, 2026
Merged
Conversation
…mpt counters The sharded finish derived the final status from the accumulated failedTests counter, which counts failed attempts — so a flaky test (failed attempt, passed retry) flipped a passed run to failed. The status is now judged by each test's last attempt per browser, matching Playwright's verdict and the non-sharded path. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The case-files endpoint validated uploads against the run's primary stream token only, so trace and attachment uploads from every other shard were rejected with 403. It now accepts shard tokens through the same fallback the events and finish endpoints already use. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Every execution reaches the server as a streamed event and is counted there; the per-shard finish added the shard totals on top, doubling all run counters. Finish now only accumulates flakyTests (absent from the events tally) and corrects the test that had asserted the doubled sums. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
|
It looks good to me, thanks for this first external pull request 🥳 let's wait for the CI |
PhenX
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: As most commits here are done by claude in this repo, I just let claude fix the issues I found in #419. The code looks valid to me at first glance. But I did not look at the souce code in great detail, as I would normally do when contributing to an open souce project. Think this is something you should keep in mind when reviewing this PR.
What & why
Fixes #419
How was it tested?
Using
npm testand by testing it with sharded playwright tests manually.Checklist
type(scope): subject)apps/docs/, README, or reporter README)