Skip to content

Fleet v2: reusable review shim + config alignment - #41

Merged
jlocke2 merged 1 commit into
masterfrom
agentic-readiness/fleet-v2
Jul 21, 2026
Merged

Fleet v2: reusable review shim + config alignment#41
jlocke2 merged 1 commit into
masterfrom
agentic-readiness/fleet-v2

Conversation

@jlocke2

@jlocke2 jlocke2 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Converts this repo's Claude review workflow to a thin shim over the org-wide reusable workflow (PipelineDeals/pipeline_deals/.github/workflows/claude-review-reusable.yml).

  • Reusable review shim: the shim owns only triggers, concurrency, and the repo-specific prompt. Review logic, caps, and generic guidance live in the reusable, so fleet-wide fixes become one PR to pipeline_deals while this repo keeps its own prompt.
  • Prompt rewritten for a library: the old prompt reviewed a phantom Rails app (account_id scoping, N+1/index checks, Sidekiq job checklists, none of which apply to a DB-less packaged gem). The new prompt covers bugs, public-API compatibility for gem consumers, thread safety, gemspec/dependency hygiene, and conventions per AGENTS.md.
  • AGENTS.md header: fixed the # CLAUDE.md heading left over from the rename.
  • Read-deny alignment: extended permissions.deny in .claude/settings.json so Read is blocked for the same secret-file patterns the guard hook already Edit-blocks.

🤖 Generated with Claude Code

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@jlocke2
jlocke2 requested a review from sevgibson July 21, 2026 18:42

@sevgibson sevgibson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving — mechanical Fleet v2 consolidation, verified against the #18519 reusable pattern (which is merged, so the @master reference resolves). .claude/settings.json change is additive secret-deny hardening (nothing loosened); claude-review.yml becomes a thin shim -> reusable@master with synchronize/concurrency/statuses:write and the repo-specific prompt preserved; AGENTS.md header rename. Low risk.

@jlocke2
jlocke2 merged commit 1f8badf into master Jul 21, 2026
1 check passed
@jlocke2
jlocke2 deleted the agentic-readiness/fleet-v2 branch July 21, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants