fix: align command prompts with active shell - #443
Draft
zhuowp wants to merge 3 commits into
Draft
Conversation
Signed-off-by: zhuowp <zwp-1989@qq.com>
Signed-off-by: zhuowp <zwp-1989@qq.com>
Signed-off-by: zhuowp <zwp-1989@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked on an official CodeWhale release; keep draft.
Commands submitted to the legacy Bash tool can contain Unix syntax even when the runtime selects PowerShell. Pin the shell-aware CodeWhale candidate and make application instructions follow the actual execution shell instead of prescribing Unix examples.
The engine change derives tool and command guidance from the existing dispatcher, covers Bash/sh/zsh/cmd/fish/custom paths, and leaves execution, permissions, tool names, and background semantics unchanged. The parent guard pins the review candidate explicitly; published r13 branches and tags are unchanged.
Dependency: Pinvou/CodeWhale#42 (candidate 0d409a97802179f1df9bcdbef185c1bfb5dc23e2). Upstream: Hmbown/Codewhale#5900.
Validation:
These are focused Windows PowerShell 5.1 simulations, not full desktop or non-Windows runtime coverage. The exported catalog and standalone evaluation schemas differ in the documented anyOf sanitization. See docs/shell-guidance-evaluation.md for full methodology and limits.
Independent AI-assisted review accepted the scoped source changes. Integration review found that scripts/verify-public-submodule.sh still requires immutable r13, which differs from this candidate. An authorized Pinvou/CodeWhale maintainer must integrate #42 and publish a new immutable tag; then align the parent gitlink, verifier, guard, and docs to the actual release and rerun CI. zhuowp has no push permission to that official repository. The release verifier is intentionally not weakened and r13 is not moved. This PR stays draft until that dependency is resolved.