fix(search): update stale chain-tail copy and backend list - #39
Open
asto18089 wants to merge 1 commit into
Open
Conversation
The r12 chain-tail switch (Hmbown#35) moved the keyless fallback for API-backed [search] providers from DuckDuckGo straight to Bing, but the web_search module doc and the model-visible description still claimed a DuckDuckGo hop, and the all-backends-down suggestion listed only five of the seven selectable API-backed providers (missing searxng and sofya). Align the copy with the actual chain, complete the suggestion list, and add the missing CHANGELOG entry for the switch. Signed-off-by: asto18089 <asto18089@126.com>
|
Thanks @asto18089 for taking the time to contribute. This repository is observing a maintainer-managed PR intake gate in dry-run mode, so this pull request is staying open. This note helps maintainers prepare the allowlist before any enforcement is considered. Please read |
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
No-Issue: the CodeWhale repo tracks no issues; this batch is tracked as Pinvou/pinvou-agent#377 (r12 review leftovers).
Leftovers from the r12 release review (Pinvou/pinvou-agent#375, tracked as Pinvou/pinvou-agent#377): after #35 moved the keyless fallback tail for API-backed
[search]providers from DuckDuckGo straight to Bing, three foundation-side spots still describe the old DuckDuckGo hop or an incomplete backend list. Docs/diagnostics only — no behavior change.Changes
web_searchdescription (crates/tui/src/tools/web_search.rs:106): no longer claims "Configured API backends visibly degrade through DuckDuckGo then Bing"; now states the actual behavior — a visible degrade through the keyless Bing tail — matching the wording already used incrates/tui/src/config/search.rs.web_search.rs:1-7): the chain is now described as provider-native search, configured API search, then a keyless Bing tail chosen by reachability; API outages never route through DuckDuckGo, while the configured DuckDuckGo route keeps its own one-way Bing scrape fallback.crates/tui/src/tools/web/backend.rs:264): now lists all seven selectable API-backed providers(tavily, bocha, metaso, searxng, baidu, volcengine, sofya)—searxngandsofyawere missing, althoughtools/spec.rsanddocs/CONFIGURATION.mdboth count them as API-backed.\[Unreleased\] / Fixedentry for the fix(search): API 后端失败兜底从 DuckDuckGo 换成 Bing #35 chain-tail switch.Not included
The optional DuckDuckGo image-search Bing fallback in
web_run.rs(item 4 of the tracking issue) is a new scraping adapter with its own parsing surface and tests, not a copy/diagnostics cleanup; left out of this PR to keep the batch reviewable.Verification
cargo test -p codewhale-tui --lib tools::web::backend— 10 passed, includingforkguard_api_provider_chain_tail_is_bingand the all-backends-down error-message test.cargo test -p codewhale-tui --lib tools::web_search— 66 passed.cargo fmt -p codewhale-tui -- --check— clean../scripts/fork-guard.sh --fast— all fingerprint layers pass; the only two failures are the layer-0 gitlink topology check, which resolves when the next baseline batch registers this commit (the tracking issue defers the parent gitlink to the next baseline batch).Signed-off-by: asto18089 asto18089@126.com