Skip to content

fix(shell): decode Windows output reliably #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
h3c-hexin wants to merge 5 commits into from
Closed

fix(shell): decode Windows output reliably #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
245a584
fix(shell): decode Windows output reliably
zhuowp Aug 25, 2026
e99f841
fix(shell): remove redundant decoder loop
h3c-hexin Aug 26, 2026
948224d
ci: verify shell regressions on Windows
h3c-hexin Aug 26, 2026
603efe7
test(shell): make UTF-8 finalization deterministic
h3c-hexin Aug 26, 2026
bb3f307
ci: rerun contribution gate after PR updates
h3c-hexin Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/pinvou-fork-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,16 @@ jobs:
run: cargo check --workspace --all-targets --locked
- name: Run Pinvou fork regression tests
run: cargo test -p codewhale-tui --lib forkguard_ --locked

windows-shell:
name: Windows shell regressions
runs-on: windows-latest
timeout-minutes: 45
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
- uses: Swatinem/rust-cache@v2
with:
cache-on-failure: true
- name: Run shell regression tests
run: cargo test -p codewhale-tui --lib tools::shell --locked
2 changes: 1 addition & 1 deletion .github/workflows/pr-gate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Contribution gate - pull requests

on:
pull_request_target:
types: [opened, reopened]
types: [opened, reopened, synchronize]

permissions:
contents: read
Expand Down
2 changes: 1 addition & 1 deletion crates/tui/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,4 +130,4 @@ objc2 = "0.6.3"
objc2-foundation = { version = "0.3.2", default-features = false, features = ["std", "NSArray", "NSDictionary", "NSError", "NSObject", "NSString", "NSURL"] }

[target.'cfg(target_os = "windows")'.dependencies]
windows = { version = "0.62", features = ["Win32_Foundation", "Win32_Media_Audio", "Win32_Security", "Win32_Security_Authorization", "Win32_Storage_FileSystem", "Win32_System_Console", "Win32_System_Diagnostics_Debug", "Win32_System_Diagnostics_ToolHelp", "Win32_System_Environment", "Win32_System_JobObjects", "Win32_System_Registry", "Win32_System_Threading", "Win32_UI_WindowsAndMessaging"] }
windows = { version = "0.62", features = ["Win32_Foundation", "Win32_Globalization", "Win32_Media_Audio", "Win32_Security", "Win32_Security_Authorization", "Win32_Storage_FileSystem", "Win32_System_Console", "Win32_System_Diagnostics_Debug", "Win32_System_Diagnostics_ToolHelp", "Win32_System_Environment", "Win32_System_JobObjects", "Win32_System_Registry", "Win32_System_Threading", "Win32_UI_WindowsAndMessaging"] }
Loading
Loading